-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional IBDO parameter diff options. #609
Add additional IBDO parameter diff options. #609
Conversation
We're replacing the default behavior with a new behavior; is there a way to explicitly get the current behavior or is the current behavior being abandoned? EDIT: Ah, we're making "1." the default behavior, but it's an implicit-only "option". The way you specify it is to not specify an incompatible option. |
Sorry ... poorly phrased. This PR will make:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor tweaks suggested
b295e01
to
084ddcf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor comments, overall looks good though.
084ddcf
to
f69e69d
Compare
Currently, IBaseDataObjectDiffHelper returns all of the parameter keys and values for both IBDO's if there is any difference. This can make finding the actually differences difficult if there are a lot of parameters.
This PR does the following: