Updating FlexibleDateTimeFormatter to cover edge cases #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arp-0984
changed the title
jpdahlke
added
priority
jdcove2
approved these changes
Jun 18, 2024
drivenflywheel
approved these changes
Jun 18, 2024
cfkoehler
pushed a commit
to cfkoehler/emissary
that referenced
this pull request
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding extra date format patterns to cover edge cases and updating characters to remove from dates.
Attempting these formats is optional and specified with a boolean passed to the parse() function. The basic set of formats (FORMAT_DATETIME_MAIN) are attempted first to parse the date, and if none of them are successful, then the more comprehensive set of date formats (FORMAT_DATETIME_EXTRA) are attempted.
Testing with the new patterns covers all the edge cases I could find. I attempted to explain the new patterns in the config file. Utilizing DateTimeFormatter is tricky because it requires an exact match of a pattern to the provided date string. The goal here is not to be able to literally parse any date, but just match the behavior of the existing DateTimeFormatterLegacy class.