updating RegressionTest generateAnswers for when two classes are used for test .dat & answer files #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drivenflywheel
requested changes
Jun 18, 2024
There was a problem hiding this comment.
This is fundamentally broken - in fact, we'll also need to rework the related changes in the UnitTest class because these changes aren't thread-safe, and could corrupt results when concurrently testing multiple classes that extend UnitTest or ExtractionTest. We can't use a static member in the base class to "store" the answer file paths.
h/t to @jdcove2 for noticing and pointing this out.
src/test/java/emissary/test/core/junit5/RegressionTestUtil.java
Outdated
Show resolved
Hide resolved
…ided in getMyTestParameterFiles
sambish5
force-pushed
the
generateAnswers-getTestParams
branch
from
5580001 to
abaa765
Compare
|
updated based on the new thread-safe version of UnitTest (#826) that allows for different directories used for test data/answer files |
sambish5
changed the title
src/test/java/emissary/test/core/junit5/RegressionTestUtil.java
Outdated
Show resolved
Hide resolved
drivenflywheel
requested changes
Jun 25, 2024
drivenflywheel
approved these changes
Jun 26, 2024
jdcove2
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
generateAnswersto be able to generate answer files in the correct location whengetMyTestParameterFilesis passed two separate classes. This allows files to generate/regenerate in the provided answer class, based on .dat files in the other class directory.