Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deny view outputs based on wildcard suffix #830

Conversation

rupert-griffin
Copy link
Collaborator

Can now deny additional items with a filter class by appending a wildcard * character to a given DENYLIST config.
This applies to all filters except for those that have overridden filter() to not check for output types.

@rupert-griffin rupert-griffin added enhancement An enhancement or update to an existing feature framework This change will impact the core framework labels Jun 21, 2024
@rupert-griffin rupert-griffin force-pushed the em-2863_Add_ability_to_deny_view_outputs_based_on_wildcard_at_the_end_of_the_view_name branch from f9e1b72 to c2332e8 Compare June 26, 2024 20:49
@jpdahlke jpdahlke modified the milestones: v8.6.0, v8.7.0 Jun 26, 2024
@fbruton fbruton requested a review from drivenflywheel July 12, 2024 11:23
@cfkoehler cfkoehler self-requested a review July 23, 2024 09:19
@cfkoehler cfkoehler self-requested a review July 24, 2024 18:04
cfkoehler
cfkoehler previously approved these changes Jul 24, 2024
@cfkoehler cfkoehler self-requested a review July 24, 2024 18:05
@cfkoehler
Copy link
Collaborator

cfkoehler commented Jul 24, 2024

Latest commit needs the formatter run:
Not sure why it is only showing on the RHEL8 runner and not the others. But I get a diff locally after a build.

sh contrib/ci/detect-changes.sh
The build changed files in worktree:
 M src/main/java/emissary/output/filter/AbstractFilter.java

cfkoehler
cfkoehler previously approved these changes Jul 24, 2024
Copy link
Collaborator

@drivenflywheel drivenflywheel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to make sure this isn't going to cause downstream mayhem with existing DENYLIST config entries.

@cfkoehler cfkoehler self-requested a review July 25, 2024 10:51
@rupert-griffin rupert-griffin force-pushed the em-2863_Add_ability_to_deny_view_outputs_based_on_wildcard_at_the_end_of_the_view_name branch from 9cf166d to 5e1fffe Compare July 26, 2024 17:07
@rupert-griffin rupert-griffin force-pushed the em-2863_Add_ability_to_deny_view_outputs_based_on_wildcard_at_the_end_of_the_view_name branch from 0f2a0df to ffcc64f Compare July 31, 2024 14:54
@jpdahlke jpdahlke modified the milestones: v8.7.0, v8.8.0 Aug 1, 2024
@cfkoehler cfkoehler added the priority This has mirrored work driving the need label Sep 5, 2024
@cfkoehler cfkoehler added this to the v8.11.0 milestone Sep 5, 2024
@cfkoehler cfkoehler removed this from the v8.11.0 milestone Sep 5, 2024
@jpdahlke jpdahlke added this to the v8.11.0 milestone Sep 6, 2024
@jpdahlke jpdahlke merged commit 4b9003e into NationalSecurityAgency:main Sep 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or update to an existing feature framework This change will impact the core framework priority This has mirrored work driving the need
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants