-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deny view outputs based on wildcard suffix #830
Merged
jpdahlke
merged 17 commits into
NationalSecurityAgency:main
from
rupert-griffin:em-2863_Add_ability_to_deny_view_outputs_based_on_wildcard_at_the_end_of_the_view_name
Sep 10, 2024
Merged
Deny view outputs based on wildcard suffix #830
jpdahlke
merged 17 commits into
NationalSecurityAgency:main
from
rupert-griffin:em-2863_Add_ability_to_deny_view_outputs_based_on_wildcard_at_the_end_of_the_view_name
Sep 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drivenflywheel
requested changes
Jun 21, 2024
f9e1b72
to
c2332e8
Compare
cfkoehler
reviewed
Jul 23, 2024
cfkoehler
previously approved these changes
Jul 24, 2024
Latest commit needs the formatter run:
|
cfkoehler
previously approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to make sure this isn't going to cause downstream mayhem with existing DENYLIST config entries.
9cf166d
to
5e1fffe
Compare
rupert-griffin
commented
Jul 26, 2024
0f2a0df
to
ffcc64f
Compare
drivenflywheel
approved these changes
Sep 5, 2024
cfkoehler
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
An enhancement or update to an existing feature
framework
This change will impact the core framework
priority
This has mirrored work driving the need
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can now deny additional items with a filter class by appending a wildcard
*
character to a givenDENYLIST
config.This applies to all filters except for those that have overridden
filter()
to not check for output types.