removing public modifiers from junit5 tests where applicable #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambish5
added
tech-debt
drivenflywheel
previously approved these changes
Jul 25, 2024
dev-mlb
previously approved these changes
Jul 25, 2024
jpdahlke
previously approved these changes
Jul 30, 2024
sambish5
force-pushed
the
remove-public-from-tests
branch
from
032fdac to
10d84d2
Compare
jpdahlke
approved these changes
Jul 30, 2024
dev-mlb
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to comply with JUnit5 (and subsequently sonar), public modifiers for test declaration are no longer necessary, so to have it consistent across emissary, went through and changed the tests where public is not needed.