Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errorprone: BanClassLoader #907

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

jpdahlke
Copy link
Collaborator

@jpdahlke jpdahlke commented Sep 1, 2024

I'm not sure that this is used anywhere else, but now that junit4 is gone I'm not sure that it's required to exist in order to work around whatever was the original issue?

@jpdahlke jpdahlke added the tech-debt Low-impact cleanup and upkeep label Sep 1, 2024
@jpdahlke jpdahlke requested a review from dev-mlb September 1, 2024 16:47
@jpdahlke
Copy link
Collaborator Author

jpdahlke commented Sep 1, 2024

This must have been to solve a transient issue since I did not see failures locally at first but I do now.

I could use an annotation to quiet the BanClassLoader rule from triggering on this class and perhaps move it to the test.junit5.extensions package instead?

@jpdahlke jpdahlke marked this pull request as draft September 1, 2024 18:11
@jpdahlke jpdahlke added the test-only The change only impacts test code label Sep 1, 2024
@jpdahlke jpdahlke changed the title remove EmissaryIsolatedClassLoaderExtension class errorprone: BanClassLoader Sep 1, 2024
@jpdahlke jpdahlke added this to the v8.11.0 milestone Sep 6, 2024
@jpdahlke jpdahlke marked this pull request as ready for review September 9, 2024 15:08
@cfkoehler cfkoehler self-requested a review September 10, 2024 15:23
@jpdahlke jpdahlke merged commit f4d7b67 into NationalSecurityAgency:main Sep 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Low-impact cleanup and upkeep test-only The change only impacts test code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants