Adding support to link a tld to a child IBDO for inheriting parameters #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbruton
requested changes
Sep 11, 2024
fbruton
reviewed
Sep 11, 2024
fbruton
reviewed
Sep 11, 2024
…nherited keys and moved it into the helper method, changed parameter inheritance ordering logic
fbruton
requested changes
Sep 12, 2024
Co-authored-by: fbruton <[email protected]>
Co-authored-by: fbruton <[email protected]>
Co-authored-by: fbruton <[email protected]>
dev-mlb
reviewed
Oct 25, 2024
| @@ -288,6 +292,28 @@ public BaseDataObject(final byte[] newData, final String name, final String form | |||
| } | |||
| } | |||
|
|
|||
| public BaseDataObject(final byte[] newData, final String name, @Nullable final String form, IBaseDataObject tld) { | |||
| setData(newData); | |||
There was a problem hiding this comment.
Any reason not to use this(newData, name, form);? Do you not want the creation timestamp set??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An effort to link children to the top level document to inherit their metadata instead of copying it down.