Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update 'dep.' names and use 'plugin.' prefix for plugins in pom #923

Merged
merged 1 commit into from
Sep 13, 2024
Merged

update 'dep.' names and use 'plugin.' prefix for plugins in pom #923

merged 1 commit into from
Sep 13, 2024

Conversation

jpdahlke
Copy link
Collaborator

  • drop numeric portion in name for deps
  • use "plugin." for plugin versions instead of "dep."
  • annotate all plugin versions used
  • sync jxr plugin on 3.3.0 (it was called out twice with different versions)

If this went too far with annotating all the versions I can scale it back, but having an easy way to find all plugin versions was nice.

@jpdahlke jpdahlke added the tech-debt Low-impact cleanup and upkeep label Sep 12, 2024
@jpdahlke jpdahlke changed the title update 'dep.' names and use 'plugin.' prefix for plugins update 'dep.' names and use 'plugin.' prefix for plugins in pom Sep 12, 2024
cfkoehler
cfkoehler approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@cfkoehler cfkoehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the scope is ok. Able to follow the changes

pom.xml Show resolved Hide resolved
@jpdahlke jpdahlke added this to the v8.12.0 milestone Sep 12, 2024
@jpdahlke jpdahlke merged commit 4d84b8d into NationalSecurityAgency:main Sep 13, 2024
13 checks passed
@jpdahlke jpdahlke added BPD Change to the Build, Package, or Deploy process and removed tech-debt Low-impact cleanup and upkeep labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfkoehler cfkoehler cfkoehler approved these changes

@sambish5 sambish5 sambish5 approved these changes

@fbruton fbruton fbruton approved these changes

Assignees
No one assigned
Labels
BPD Change to the Build, Package, or Deploy process
Projects
None yet
Milestone
v8.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jpdahlke @fbruton @sambish5 @cfkoehler