Blacklist Google Play Services internal members #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plamen5kov
approved these changes
Nov 3, 2017
| @@ -498,8 +504,7 @@ private void writeMethods(Set<String> methodsSet) { | |||
| } | |||
|
|
|||
| private void cacheMethodBySignature(Method m) { | |||
| mapNameMethod = new HashMap<String, Method>(); | |||
| String currMethodSig = getMethodFullSignature(m); | |||
| String currMethodSig = m.getName();//getMethodFullSignature(m); | |||
There was a problem hiding this comment.
change variable name to better describe its use and remove the comment if it's no longer necessary
| @@ -441,6 +445,8 @@ private void generateInterfaceConstructorCommentBlock(JavaClass classInterface, | |||
| private void processMethod(Method m, JavaClass clazz, boolean isInterface, Set<String> methodsSet) { | |||
| String name = m.getName(); | |||
|
|
|||
| if (name.startsWith("zz")) return; | |||
There was a problem hiding this comment.
add a comment explaining why this is necessary or link to an issue should be sufficient
| @@ -613,6 +618,10 @@ private String getMethodParamSignature(JavaClass clazz, Method m) { | |||
|
|
|||
| //field related | |||
| private void processField(Field f, JavaClass clazz) { | |||
| String fieldName = f.getName(); | |||
|
|
|||
| if (fieldName.startsWith("zz")) return; | |||
|
I've got a separate issue open regarding the tests - I'd have to setup a small infrastructure too, and I did not want to pollute this PR - #25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes will open the path to fewer typescript errors when typescript-compiling against definitions generated from Google Play Services plugins.
For example after feeding the following android plugins (aars) into the generator, there is only a handful of errors that we need yet to find a way to address:
plugins:
errors list:
8 out of the 13 errors are one and the same error - a public class has a static public member called
CastApi, but the public class also has a nested class of the same name, which is causing the collisions.