Support: ignore bad renderScale on Vegas

addresses NatronGitHub/openfx-misc#66
NatronGitHub · Jun 14, 2020 · eec47f4 · eec47f4
1 parent 9a04485
commit eec47f4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/Support/Library/ofxsImageEffect.cpp b/Support/Library/ofxsImageEffect.cpp
@@ -2493,9 +2493,10 @@ namespace OFX {
     setParamSetHandle(paramSet);      
 
     const ImageEffectHostDescription &hostDescription = *getImageEffectHostDescription();
-    _hostIsResolve = (hostDescription.hostName.substr(0, 14) == "DaVinciResolve");  // Resolve gives bad image properties (RS is always 1 and field is None)
+    _hostIsResolve = (hostDescription.hostName.rfind("DaVinciResolve", 0) == 0);  // Resolve gives bad image properties (RS is always 1 and field is None)
     _hostIsFusion = (hostDescription.hostName == "com.eyeonline.Fusion") || (hostDescription.hostName == "com.blackmagicdesign.Fusion"); // Fusion gives inverse RS props in inargs and on the images
-    _ignoreBadRenderScale = _hostIsResolve || _hostIsFusion;
+    _hostIsVegas = (hostDescription.hostName.rfind("com.sonycreativesoftware.vegas", 0) == 0); // Vegas, and probably VegasMovieStudio, always use renderScale, and do not set it in the image props, see https://github.com/NatronGitHub/openfx-misc/issues/66#issuecomment-562783481
+    _ignoreBadRenderScale = _hostIsResolve || _hostIsFusion || _hostIsVegas;
   }
 
   /** @brief dtor */

diff --git a/Support/include/ofxsImageEffect.h b/Support/include/ofxsImageEffect.h
@@ -1854,6 +1854,12 @@ namespace OFX {
     */
     bool _hostIsFusion;
 
+    /** @brief used to disable checks on some hosts.
+
+    in Sony Vegas, kOfxImageEffectPropRenderScale is <1 in the inArgs for downscaled render, but =1. on the images
+    */
+    bool _hostIsVegas;
+
     /** @brief ignore render scale checks */
     bool _ignoreBadRenderScale;