Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android 15 Private Space Integration #2345

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TSonono
Copy link

@TSonono TSonono commented Nov 24, 2024

#2338

Note that this is a draft and not ready for review/merge.

This has the basic functionality for a usable Private Space integration.

What is supported:

  • Unlock and lock the private space by pressing or long pressing the 3 dots in the KISS search bar and then press the applicable unlock/lock private space button.
  • Private space apps are shown and openable in the KISS app list/searchable/history.

What is missing (first two bullets as per https://developer.android.com/about/versions/15/behavior-changes-all#private-space-launcher-apps):

  • "separate launcher container for apps installed in the private space"
  • "Install Apps" button that launches an implicit intent to install apps into the user's private space".
  • After private space has been disabled, the apps must be removed from the app list, history and search view rather than being greyed out, which is currently the case.
  • Perhaps an option to disable shortcuts from apps in the private space in the KISS search view. It can be annoying if there's an app in both the standard user and the private space that has a lot of shortcuts with shortcuts from both apps showing.

I might work on this on and off for some weekends a head. If someone else is implementing this, let me know so that I don't work on this in vain. If someone wants to continue the work of this PR (in what I would assume a quicker pace than I have time for), I would be fine with that too, just let me know.

This has the basic functionality for a useable Private Space
interaction. What is missing is the "separate launcher container
for apps installed in the private space", as well as the "an "Install
Apps" button that launches an implicit intent to install apps into
the user's private space".
@TBog
Copy link
Collaborator

TBog commented Nov 24, 2024

Thank you for working on this!

return !manager.isQuietModeEnabled(user);
}

private void switchPrivateSpaceState() {
Copy link
Collaborator

@TBog TBog Nov 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could annotate the method switchPrivateSpaceState instead of asserting inside
@RequiresApi(35)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants