forked from mosip/id-repository
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES-422 review comment fixes #2
Open
ase-101
wants to merge
11
commits into
Neha2365:MOSIP-28242-uin-generation-failed-invalid-input-parameter-verified-attributes-LTS
Choose a base branch
from
ase-101:MOSIP-28242-uin-generation-failed-invalid-input-parameter-verified-attributes-LTS
base: MOSIP-28242-uin-generation-failed-invalid-input-parameter-verified-attributes-LTS
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kameshsr <[email protected]>
* MOSIP-30419 Fixed update count Issue Signed-off-by: kameshsr <[email protected]> * MOSIP-30420 Fixed update identity issue Signed-off-by: kameshsr <[email protected]> --------- Signed-off-by: kameshsr <[email protected]>
* MOSIP-30420 Added validation in update identity API. Signed-off-by: kameshsr <[email protected]> Signed-off-by: Loganathan Sekar <[email protected]> * -sAdded null check Signed-off-by: kameshsr <[email protected]> Signed-off-by: Loganathan Sekar <[email protected]> * Combined 2 if condition Signed-off-by: kameshsr <[email protected]> Signed-off-by: Loganathan Sekar <[email protected]> * Update IdRepoServiceImpl.java Signed-off-by: Loganathan Sekar <[email protected]> --------- Signed-off-by: kameshsr <[email protected]> Signed-off-by: Loganathan Sekar <[email protected]> Co-authored-by: Loganathan Sekar <[email protected]>
Signed-off-by: kameshsr <[email protected]>
* MOSIP-30419 Removed update count for update draft Signed-off-by: kameshsr <[email protected]> * MOSIP-30419 Refactored code Signed-off-by: kameshsr <[email protected]> --------- Signed-off-by: kameshsr <[email protected]>
* MOSIP-30592 Fixed update count issue Signed-off-by: kameshsr <[email protected]> * MOSIP-30592 Added missing attributes from policy for update count Signed-off-by: kameshsr <[email protected]> --------- Signed-off-by: kameshsr <[email protected]>
Signed-off-by: Neha Farheen <[email protected]>
Signed-off-by: Neha Farheen <[email protected]>
Signed-off-by: Neha Farheen <[email protected]>
Signed-off-by: Neha Farheen <[email protected]>
Signed-off-by: ase-101 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.