Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES-422 review comment fixes #2

Open
wants to merge 11 commits into
base: MOSIP-28242-uin-generation-failed-invalid-input-parameter-verified-attributes-LTS
Choose a base branch
from

Conversation

ase-101
Copy link

@ase-101 ase-101 commented Dec 7, 2023

No description provided.

kameshsr and others added 11 commits November 30, 2023 12:40
* MOSIP-30419 Fixed update count Issue

Signed-off-by: kameshsr <[email protected]>

* MOSIP-30420 Fixed update identity issue

Signed-off-by: kameshsr <[email protected]>

---------

Signed-off-by: kameshsr <[email protected]>
* MOSIP-30420 Added validation in update identity API.

Signed-off-by: kameshsr <[email protected]>
Signed-off-by: Loganathan Sekar <[email protected]>

* -sAdded null check

Signed-off-by: kameshsr <[email protected]>
Signed-off-by: Loganathan Sekar <[email protected]>

* Combined 2 if condition

Signed-off-by: kameshsr <[email protected]>
Signed-off-by: Loganathan Sekar <[email protected]>

* Update IdRepoServiceImpl.java

Signed-off-by: Loganathan Sekar <[email protected]>

---------

Signed-off-by: kameshsr <[email protected]>
Signed-off-by: Loganathan Sekar <[email protected]>
Co-authored-by: Loganathan Sekar <[email protected]>
* MOSIP-30419 Removed update count for update draft

Signed-off-by: kameshsr <[email protected]>

* MOSIP-30419 Refactored code

Signed-off-by: kameshsr <[email protected]>

---------

Signed-off-by: kameshsr <[email protected]>
* MOSIP-30592 Fixed update count issue

Signed-off-by: kameshsr <[email protected]>

* MOSIP-30592 Added missing attributes from policy for update count

Signed-off-by: kameshsr <[email protected]>

---------

Signed-off-by: kameshsr <[email protected]>
Signed-off-by: Neha Farheen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants