Add helper functions for handling cookies #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know you linked in-progress PRs, but one way to verify this works is to implement with a current broker, like Fidelity, since it currently doesn't save cookies and asks for SMS 2fa every login |
NelsonDane
requested changes
Aug 29, 2024
|
@NelsonDane Can we please get a review on this again? I understand that Fidelity is throwing an error, but I am getting the same error thrown on main. That is separate from this. I have tested this on docker and discord and it works perfectly for me. Please give your input. Thank you. |
Merged
NelsonDane
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds helper functions for easily storing cookies for Selenium drivers. This will be of great help to #317, #314, #295, and #316. All of these PRs could utilize this in order to easily implement storing session cookies. Fidelity could use this too.