Edit lll docstrings
#1566
Merged
Edit lll docstrings
#1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joschmitt
commented
Oct 30, 2023
joschmitt
commented
Oct 30, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1566 +/- ##
==========================================
- Coverage 84.20% 84.18% -0.02%
==========================================
Files 94 94
Lines 36658 36654 -4
==========================================
- Hits 30867 30857 -10
- Misses 5791 5797 +6 ☔ View full report in Codecov by Sentry. |
|
Marking this as draft for now. I'm still reverse engineering what these functions want (bases vs. generating systems for example). |
|
I'm happy with this for now. (All my changes are based on educated guessing and reverse-engineering though.) |
fingolfin
reviewed
Nov 23, 2023
fingolfin
reviewed
Nov 23, 2023
fingolfin
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to fix and clarify the docstrings for the various
lll_(gram)_(with_transform)functions. I'm no expert, so I hope I did not misunderstand anything.