Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specializations for LinAlg on Z, depends, need the solve_triu in AA #1591

Merged
merged 10 commits into from
Dec 5, 2023

Conversation

fieker
Copy link
Contributor

@fieker fieker commented Dec 1, 2023

A range of things

  • various solve_tri* functions
  • native _hcat, _vcat
  • native add_rows, add_columns
  • native maximum(nbits, A)
  • hardarmad_bound2

fieker and others added 10 commits November 27, 2023 11:58
 - _hcat, _vcat for reduce((h|v)cat, ...)
 - add_rows!, add_colums!
 - hadramat_bound2
 - maximum(nbits, )
 - some solve_tri(u|l) (used in/ far Strassen and the new Det)
@thofma thofma closed this Dec 5, 2023
@thofma thofma reopened this Dec 5, 2023
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 95 lines in your changes are missing coverage. Please review.

Comparison is base (9c780a4) 84.22% compared to head (8e5f2c5) 84.04%.
Report is 5 commits behind head on master.

Files Patch % Lines
src/flint/fmpz_mat.jl 62.29% 69 Missing ⚠️
src/flint/nmod_mat.jl 0.00% 22 Missing ⚠️
src/HeckeMiscMatrix.jl 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1591      +/-   ##
==========================================
- Coverage   84.22%   84.04%   -0.18%     
==========================================
  Files          94       94              
  Lines       36654    36876     +222     
==========================================
+ Hits        30870    30992     +122     
- Misses       5784     5884     +100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thofma thofma merged commit 4c9cbe2 into Nemocas:master Dec 5, 2023
18 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants