Set observer mode correctly on joining a team

[VantoNortim]

Description

If player joins a team while game is in progress set them to spectate in first person. If no players set them to freecam.
Spawn player as soon as they selected a loadout
Set loadout to MPN if trying to spawn with invalid one

Toolchain

• Windows MSVC VS2022

Linked Issues

• fixes Players joining a team during an ongoing round are placed into observer mode #273

[Rainyan]

There seems to be a bug with the free-fly observing as a dead player.

Steps to reproduce:

Set up a convenience bind:

alias "+GoFast" "host_timescale 10"
alias "-GoFast" "host_timescale 1"
bind o +GoFast

this allows you to hold down the O key (or any other bind) to speed up time temporarily.

• Load a CTG map: map nt_oilstain_ctg
• Join a playing team
• Set sv_cheats 1
• Set mp_forcecamera 0 to allow non-POV dead spec
• Set mp_neo_warmup_round_time 0
• Set bot_attack 0 to prevent the bots from going wild
• Spawn 4 bots: bot; bot; bot; bot
• Wait for the first round to begin
• Choose your class and loadout, and spawn in the world
• Use the GoFast bind to waste time until around 2 minutes remaining in the round clock.
  • Spending some time like this works around [BUG] Players are (sometimes) able to respawn  #793
• Use kill to suicide
• Wait for the death fade sequence to pass, so you have keyboard control
• Try to fly around in the free-fly dead spec mode

What should happen:

• You are able to fly around freely, and also to enter other obs modes by using the space bar

What actually happens:

• You are stuck observing your own corpse from the third person

[AdamTadeusz]

Working on comp server variable, and its very easy using the existing hl variables to restrict the observer camera to only spectate teammates, and crucially to only spectate in eye. If theres a weird spectate mode that allows you to follow someone through their eyes but see their 3rd person model, maybe it would be easier just to restrict that observer mode? I don't see much use for it anyway. Also you can replicate that behavior using cl_first_person_uses_worldmodel 1

[VantoNortim]

Working on comp server variable, and its very easy using the existing hl variables to restrict the observer camera to only spectate teammates, and crucially to only spectate in eye. If theres a weird spectate mode that allows you to follow someone through their eyes but see their 3rd person model, maybe it would be easier just to restrict that observer mode? I don't see much use for it anyway. Also you can replicate that behavior using cl_first_person_uses_worldmodel 1

I can remove the camera changing stuff and just keep the respawn improvements. Since that should make fix things like respawning in TDM.