Thermals V3 #776
Open
Thermals V3 #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamTadeusz
added
the
Changes in neoAssets
brysondev
previously approved these changes
Nov 2, 2024
| @@ -16,6 +19,7 @@ struct PS_INPUT | |||
| float4 main( const PS_INPUT i ) : COLOR | |||
| { | |||
| const float4 fbColor = tex2D(FrameBuffer, i.texCoord); | |||
| const float avgBright = (fbColor.r + fbColor.g + fbColor.b) * 0.3333; | |||
| return tex2D(TvTexture, float2(min(1.0, avgBright + g_XOffset), 0.5)) * g_BrightnessScale; | |||
| const float noise = 0.9 + (tex2D(NoiseTexture, i.texCoord + float2(g_XNoiseOffset, g_YNoiseOffset)) / 10); | |||
| @@ -16,6 +19,7 @@ struct PS_INPUT | |||
| float4 main( const PS_INPUT i ) : COLOR | |||
| { | |||
| const float4 fbColor = tex2D(FrameBuffer, i.texCoord); | |||
Rainyan
requested changes
Nov 24, 2024
| @@ -16,7 +17,8 @@ BEGIN_SHADER_PARAMS | |||
| SHADER_PARAM(FBTEXTURE, SHADER_PARAM_TYPE_TEXTURE, "_rt_ThermalVision", "") | |||
| //SHADER_PARAM(BLURTEXTURE, SHADER_PARAM_TYPE_TEXTURE, "_rt_SmallHDR0", "") | |||
| SHADER_PARAM(TVTEXTURE, SHADER_PARAM_TYPE_TEXTURE, "dev/tvgrad2", "") | |||
| //SHADER_PARAM(NOISETEXTURE, SHADER_PARAM_TYPE_TEXTURE, "dev/noise", "") | |||
| SHADER_PARAM(NOISETEXTURE, SHADER_PARAM_TYPE_TEXTURE, "dev/noise", "") | |||
| SHADER_PARAM(NOISETRANSFORM, SHADER_PARAM_TYPE_VEC3, "Vector(0, 0, 0)", "") | |||
There was a problem hiding this comment.
Possibly invalid syntax for SHADER_PARAM_TYPE_VEC3 value, perhaps use [0 0 0] instead
There was a problem hiding this comment.
This tutorial https://developer.valvesoftware.com/wiki/Source_SDK_2013:_Your_Second_Shader uses brackets, I've also seen just a few numbers with no brackets somewhere else in the wiki
brysondev
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-------> SHADERS AND NEW MATERIALS IN NeotokyoRebuild/neoAssets#15 <-------
Added noise to the thermals;
Reduced initial thermal shader colour gradient offset to make dark objects stand out a bit more (using black screen with default colour of 0 0 0 to work out what I believe is the correct value) and added a multiplier to compensate for bright areas not being as bright with the offset reduction;
View models and other models now use the tvmgrad and tvmgrad2 textures respectively to colour correct. This methodology can probably be used in the night vision and especially the motion vision to get a more original colour and also make those shaders more performant and less complicated (see materials/dev/nvgrad.vtf and materials/dev/mvgrad.vtf);
The way the gradients are passed from the material to the shader can also probably be used to remove the janky way that thermoptic cloak's strength is passed to the thermoptic shader, instead of through the current modification of a convar everytime a cloaked object is drawn
Toolchain
Linked Issues