Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Feature Idea] See through smokes when using xray in spectator mode #817

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AdamTadeusz
Copy link
Contributor

Description

remove smoke grenade overlay and lower smoke particle opacity when spectating and using xray

Toolchain

  • Windows MSVC VS2022
  • Linux GCC Distro Native [Specify distro + GCC version]
  • Linux GCC 10 Sniper 3.0

Linked Issues

Copy link
Collaborator

@Rainyan Rainyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea, if we have consensus for adding this.

But with the current implementation, clients playing in the match can also toggle glow_outline_effect_enable to see past smokes, which shouldn't be allowed. We should do a IsAlive check in there somewhere so players can't abuse it.

Also, we could improve the visuals so it's more obvious to the spectator (and their audience, in case of a stream observer) that the smoke is being reduced and doesn't reflect what the players see. Increasing the alpha fraction a bit more could help(?) Drawing an outline effect to the smoke puff itself (similar to the xray feature) could be another option. But I guess we could iterate on it more later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants