-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Makefile #16
base: master
Are you sure you want to change the base?
Add Makefile #16
Conversation
deps: | ||
go get github.com/c0defellas/enzo/cmd/... | ||
|
||
install: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it not be a good idea to remove a previous install before ? some older files may remain on the dir as the project evolves. new code that wrongly imports old stuff would even work after make install since the old file would still be present on the system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I don't know this PR is useful, sorry 🤕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is useful 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found this install rule odd. I agree with @katcipis that this could leave the install in an inconsistent state... or be harmful in case of overwritten user's files.
I think the only required rule in the Makefile is "deps" for now.
deps: | ||
go get github.com/c0defellas/enzo/cmd/... | ||
|
||
install: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found this install rule odd. I agree with @katcipis that this could leave the install in an inconsistent state... or be harmful in case of overwritten user's files.
I think the only required rule in the Makefile is "deps" for now.
λ> mkdir -p $NASHPATH+"/lib" | ||
λ> cd $NASHPATH+"/lib" | ||
λ> git clone [email protected]:tiago4orion/nashcomplete.git | ||
λ> git clone [email protected]:NeowayLabs/nashcomplete.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of install
, maybe shows how to use nashget
to get the same result.
No description provided.