Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unlock event queue when handling event. #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

unlock event queue when handling event. #67

wants to merge 1 commit into from

Conversation

xpol
Copy link
Contributor

@xpol xpol commented Apr 29, 2016

  1. unlock event queue when handling event.
  2. and make lock scope smaller.

@xpol xpol mentioned this pull request Apr 29, 2016
Closed
@xpol xpol force-pushed the unlock-event-queue-when-handling-event branch from f7347f0 to 3ce13be Compare April 29, 2016 04:44
@cynron
Copy link
Member

cynron commented Apr 29, 2016

@xpol

I'm afraid PC_PRE_ALLOC_SET_IDLE inside pc__handle_event should be protected by event_mutex as we release the mutex before entering pc__handle_event

Thanks!

@xpol
Copy link
Contributor Author

xpol commented Apr 29, 2016

@cynron
Sorry.
This is last day that I work on lua-pomelo (going for another job), and I can get it working.
I'm considering shutdown lua-pomelo.

Thanks for you great help and good luck to you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xpol @cynron