Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #73 Loading NuGet dependencies in a Rosyln analyzer. #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DavidTCarpenters
Copy link

Add a package reference to NetFrabric.CodeAnalysis - Gets the dll into the build.

Include PackDependencies target - Adds the reference to the lib and analyzer.

Add all output dlls as analyzer references.

Add a package reference to NetFrabric.CodeAnalysis - Gets the dll into the build
Include PackDependencies target - Adds the reference to the lib and analyzer
Add all output dlls as analyzer references
@DavidTCarpenters
Copy link
Author

Here's a screenshot of this build referenced in another project producing analyzer warnings

image

@DavidTCarpenters
Copy link
Author

And the structure of the produced package as seen in dotpeek the analyzer required the dll to be in both the lib folder and the analyzers folder

image

@aalmada
Copy link
Member

aalmada commented Oct 19, 2023

@DavidTCarpenters Thank you so much for this PR

If my understanding is correct, it duplicates the NetFabric.CodeAnalysis assembly into the analyzers\dotnet\cs directory. This is a positive approach, but what if another analyzer places an older version there? It's regrettable that .NET no longer relies on the "Global Assembly Cache" (GAC).

I believe I'll continue with the assembly merge solution, even though it encounters issues with GitHub actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants