Fix some bug risks and code quality issues

.deepsource.toml

@@ -0,0 +1,12 @@
+version = 1
+
+test_patterns = ["test/**"]
+
+exclude_patterns = ["docs/**"]
+
+[[analyzers]]
+name = "python"
+enabled = true
+
+  [analyzers.meta]
+  runtime_version = "3.x.x"

aardvark/manage.py

@@ -299,7 +299,7 @@ def _prep_accounts(account_names):
     Considers account aliases as well as account names.
     Returns a list of account numbers
     """
-    matching_accounts = list()
+    matching_accounts = []
     account_names = account_names.split(',')
     account_names = {name.lower().strip() for name in account_names}
 

aardvark/updater/__init__.py

@@ -2,6 +2,7 @@
 from __future__ import absolute_import
 
 import copy
+import sys
 import time
 
 from blinker import Signal
@@ -45,7 +46,7 @@ def update_account(self):
 
         if not arns:
             self.current_app.logger.warn("Zero ARNs collected. Exiting")
-            exit(-1)
+            sys.exit(-1)
 
         client = self._get_client()
         try:

aardvark/view.py

@@ -3,7 +3,6 @@
 
 import better_exceptions  # noqa
 import datetime
-import json
 
 from flask import abort, jsonify
 from flask import Blueprint
@@ -32,7 +31,7 @@ def combine(self, aa):
         del aa['page']
         del aa['total']
 
-        usage = dict()
+        usage = {}
         for arn, services in aa.items():
             for service in services:
                 namespace = service.get('serviceNamespace')

test/test_config.py

@@ -269,7 +269,7 @@ def tearDown(self):
                 if self.last_transcript:
                     fptr.write(
                         '\n'.join(
-                            map(lambda x: str(x), self.last_transcript)
+                            map(str, self.last_transcript)
                             ) + '\n'
                         )