Skip to content

Commit

Permalink
Remove disabled tests that are no longer relevant
Browse files Browse the repository at this point in the history
  • Loading branch information
paulbakker committed Dec 10, 2024
1 parent 71fdeef commit 32ba05a
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 250 deletions.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -251,101 +251,6 @@ class MicrometerServletSmokeTest {
)
}

@Test
@Disabled
fun `Metrics for a successful request with data loaders`() {
mvc
.perform(
MockMvcRequestBuilders
.post("/graphql")
.contentType(MediaType.APPLICATION_JSON)
.content(
"""{"query":
| "{transform(input: [\"A madam in a racecar.\", \"A man, a plan, a canal - Panama\" ]){ index value upperCased reversed } }" }
""".trimMargin(),
),
).andExpect(status().isOk)
.andExpect(
content().json(
"""
|{
| "data":{
| "transform":[
| {
| "index":0,
| "value":"A madam in a racecar.",
| "upperCased":"A MADAM IN A RACECAR.",
| "reversed":".racecar a ni madam A"
| },
| {
| "index":1,
| "value":"A man, a plan, a canal - Panama",
| "upperCased":"A MAN, A PLAN, A CANAL - PANAMA",
| "reversed":"amanaP - lanac a ,nalp a ,nam A"
| }
| ]
| }
|}
""".trimMargin(),
false,
),
)

val meters = fetchMeters()

assertThat(meters).containsOnlyKeys("gql.dataLoader", "gql.query", "gql.resolver")

assertThat(meters["gql.dataLoader"]).isNotNull.hasSize(2)
assertThat(meters["gql.dataLoader"]?.map { it.id.tags })
.containsAll(
listOf(
Tags.of("gql.loaderBatchSize", "2").and("gql.loaderName", "reverser").toList(),
Tags.of("gql.loaderBatchSize", "2").and("gql.loaderName", "upperCaseLoader").toList(),
),
)

assertThat(meters["gql.query"]).isNotNull.hasSize(1)
assertThat(meters["gql.query"]?.first()?.id?.tags)
.containsAll(
Tags
.of("execution-tag", "foo")
.and("contextual-tag", "foo")
.and("outcome", "success")
.and("gql.operation", "QUERY")
.and("gql.operation.name", "anonymous")
.and("gql.query.complexity", "10")
.and("gql.query.sig.hash", MOCKED_QUERY_SIGNATURE.hash),
)

assertThat(meters["gql.resolver"]?.first()?.id?.tags)
.containsAll(
Tags
.of("gql.field", "Query.transform")
.and("field-fetch-tag", "foo")
.and("contextual-tag", "foo")
.and("outcome", "success")
.and("gql.operation", "QUERY")
.and("gql.operation.name", "anonymous")
.and("gql.query.complexity", "10")
.and("gql.query.sig.hash", MOCKED_QUERY_SIGNATURE.hash),
)

assertThat(meters["gql.dataLoader"]).isNotNull.hasSize(2)
assertThat(meters["gql.dataLoader"]?.map { it.id.tags })
.containsAll(
listOf(
Tags
.of("gql.loaderBatchSize", "2")
.and("gql.loaderName", "reverser")
.toList(),
Tags
.of("gql.loaderBatchSize", "2")
.and("gql.loaderName", "upperCaseLoader")
.toList(),
),
)
}

@Test
fun `Assert metrics for a syntax error`() {
mvc
Expand Down

This file was deleted.

This file was deleted.

0 comments on commit 32ba05a

Please sign in to comment.