Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending example #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Extending example #46

wants to merge 1 commit into from

Conversation

eyaltrabelsi
Copy link

  • improve(documentation): minimal requirements, creating table using spark dataframe, loading iceberg table using spark

@eyaltrabelsi eyaltrabelsi mentioned this pull request Aug 1, 2018
@rdblue
Copy link
Contributor

rdblue commented Aug 1, 2018

This changes the notebook language to Python and duplicates a cell. I don't think it is something that's ready to merge. There's also a ton of extra metadata.

Also, there's now a published version, 0.2.0, in JitPack so there's no need to duplicate build instructions here.

…dataframe, loading iceberg table using spark
@eyaltrabelsi
Copy link
Author

  1. I removed the build instructions
  2. I restored the original notebook kernel metadata
  3. I removed the redundant metadata I added
  4. regarding the duplicates a cell do you mean these (Drop and create a table in HDFS using hive tables/spark dataframe)? do you want me to write it a bit more generic ? to reserve imports only on one cell? remove the spark example ?

@eyaltrabelsi
Copy link
Author

@rdblue how does it look now ?

Parth-Brahmbhatt pushed a commit to Parth-Brahmbhatt/iceberg that referenced this pull request Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants