More fixes to local datastore use

.github/workflows/test.yml

@@ -17,6 +17,7 @@ jobs:
     env:
       METAFLOW_CONDA_DEPENDENCY_RESOLVER: ${{ matrix.resolver }}
       METAFLOW_CONDA_TEST: 1
+      METAFLOW_DATASTORE_SYSROOT_LOCAL: .metaflow
     steps:
       - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
 
@@ -43,4 +44,5 @@ jobs:
         run: |
           set -x
           which pytest
+          mkdir .metaflow
           pytest -n 16 tests

metaflow_extensions/netflix_ext/plugins/conda/conda.py

@@ -144,7 +144,7 @@ def _modified_logger(*args: Any, **kwargs: Any):
             # Prevent circular dep
             from metaflow.plugins import DATASTORES
 
-            # We will be able to cache things -- currently no caching for local
+            # We will be able to cache things -- currently no caching for local except in testing
             storage_impl = [d for d in DATASTORES if d.TYPE == self._datastore_type][0]
             self._storage = storage_impl(
                 get_conda_root(self._datastore_type)

tests/test_env_create.py

@@ -19,11 +19,6 @@
 except FileExistsError:
     pass
 
-# Create a local `.metaflow` directory for the local storage. If this is not
-# done, there are cases where there is a race in creating it causing tests to fail.
-if not os.path.isdir(os.path.join(my_dir, ".metaflow")):
-    os.mkdir(os.path.join(my_dir, ".metaflow"))
-
 with os.scandir(os.path.join(my_dir, "environments")) as it:
     for entry in it:
         if entry.is_file() and (