fix: argo and step-function config param mapping #2105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savingoyal
reviewed
Oct 17, 2024
| @@ -476,6 +476,8 @@ def _process_parameters(self): | |||
| has_schedule = self._cron() is not None | |||
| seen = set() | |||
| for var, param in self.flow._get_parameters(): | |||
| if param.IS_FLOW_PARAMETER: | |||
There was a problem hiding this comment.
@saikonen can you add a comment here for why we continue? would be helpful later on
Previously, options like `branch` and `name` (injected by the project decorator for example) could be set using `METAFLOW_BRANCH`. They now need to be set using `METAFLOW_FLOW_BRANCH`. This change is made to prevent clashes between regular metaflow configuration settings and decorator level options. No other changes are made so `METAFLOW_RUN_MAX_WORKERS` still works as expected and `METAFLOW_PYLINT` as well.
Several fixes: - fixed an issue with default values - better handling of parameter defaults as configs - handle config defaults as functions - ConfigValue is more "dict"-like - made <myflow>.configs and <myflow>.steps work properly - renamed resolve_configs to init
Specifically: - moved things out of the INFO file - added to_dict - renamed user_configs to config_parameters
Specifically: - made config values immutable - cleaned up state stored in FlowSpec - added a test exercising configs in various places
- Separate out value and file (so default and default_value and --config and --config-value) - Provide classes for step and flow config decorators with proxy objects - Split things into several files (it was getting too long) - Addressed all bugs discussed
romain-intel
force-pushed
the
feat/configs
branch
from
5fdb25c to
bc57f77
Compare
Fixed some typos and updated test to reflect latest code.
Fixed a few other issues:
- fixed an issue where a config was used in different decorators
causing it to produce an incorrect access string
- made the decorators work with or without arguments
Will only print stuff when there is an error and will print it in a non-interleaved manner.
saikonen
force-pushed
the
fix/argo-config-param-mapping
branch
from
fef6ec1 to
dfe05dc
Compare
saikonen
changed the title
romain-intel
force-pushed
the
feat/configs
branch
2 times, most recently
from
2bf8847 to
21f0c3a
Compare
romain-intel
force-pushed
the
feat/configs
branch
from
641def0 to
fc1a3b8
Compare
|
Included in #1962 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small change to fix argo/step function handling of config parameters