-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/interactive_physical_layout #4
Merged
jrsquared
merged 8 commits into
Netflix:master
from
jbrekelmans:feature/interactive_physical_layout
Nov 22, 2016
Merged
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9877f49
Initial commit
jbrekelmans 9997235
Fix accidentally introduced bug
brekelj1 1437515
Remove empty statement
brekelj1 b4ab6f5
Undo introducing more verbose syntax for semantically equivalent expr…
brekelj1 df65d30
Change the condition for calling updateData (removing regions now als…
brekelj1 1ef35fd
Merge commit 'c6e081396a5bd7ac23c673629a1a23376f13e2e4' into feature/…
brekelj1 2f34a1c
Fix bug introduced in merging from master
brekelj1 040c0ff
Added property for repositioning of nodes by dragging, fix potential …
brekelj1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,9 @@ | ||
# System | ||
.DS_Store | ||
|
||
# IDE config | ||
.idea | ||
|
||
# Generated | ||
/.jshintignore | ||
/.jshintrc | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the change? These have default empty functions so they are just no-ops if the user does not provide listeners to things they do not care about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the moment I thought all of those lambda expressions were creating functions that returned empty POJO's, but I learnt this is not the case. I'll undo them since I prefer the old syntax