-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break HTTP routes into multiple servers #1087
Conversation
This is probably easiest to review all at once, rather than commit-by-commit. We can squash merge. |
518db45
to
757f3f5
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1087 +/- ##
==========================================
+ Coverage 73.81% 73.87% +0.06%
==========================================
Files 66 66
Lines 7255 7270 +15
==========================================
+ Hits 5355 5371 +16
- Misses 1449 1453 +4
+ Partials 451 446 -5
☔ View full report in Codecov by Sentry. |
We can put Http & ws rpc on the same port, WDYT? |
3783be4
to
b7b46d0
Compare
I'll figure out why the codecov is low and fix the linting errors. I may also change default port numbers to align with what is in the current released version to maximize compatibility. |
a29c358
to
8e54844
Compare
Rebased and made the adjustments mentioned in my last message. If you don't mind taking another quick look @omerfirmak, I would really appreciate it. I'm fine with merging the http and websocket servers if you think that's a good idea. I kept them separate to follow geth's lead. Let me know if you think that's worth the effort. Note that all services that require ports are disabled by default now. Enabling them all on their default ports would look something like:
|
52de516
to
30faf73
Compare
623c678
to
b9ac10b
Compare
8fb82d0
to
6cca12a
Compare
For access control purposes.