Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: Add metrics #1155

Merged
merged 4 commits into from
Sep 10, 2023
Merged

sync: Add metrics #1155

merged 4 commits into from
Sep 10, 2023

Conversation

Exca-DK
Copy link
Contributor

@Exca-DK Exca-DK commented Aug 23, 2023

closes #1153

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (64385e8) 73.97% compared to head (33bfcb1) 74.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1155      +/-   ##
==========================================
+ Coverage   73.97%   74.01%   +0.03%     
==========================================
  Files          70       70              
  Lines        7416     7454      +38     
==========================================
+ Hits         5486     5517      +31     
- Misses       1481     1486       +5     
- Partials      449      451       +2     
Files Changed Coverage Δ
sync/sync.go 85.91% <100.00%> (+0.54%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@joshklop joshklop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably isn't good for this PR, but it would be nice to add tests for metrics imho.

Maybe with #1168

sync/sync.go Outdated Show resolved Hide resolved
sync/sync.go Show resolved Hide resolved
Copy link
Contributor

@joshklop joshklop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy uk linter

😂

sync/sync.go Outdated Show resolved Hide resolved
sync/sync.go Show resolved Hide resolved
@joshklop joshklop merged commit 4e3c55a into NethermindEth:main Sep 10, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add metrics for sync status
2 participants