-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync: Add metrics #1155
sync: Add metrics #1155
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1155 +/- ##
==========================================
+ Coverage 73.97% 74.01% +0.03%
==========================================
Files 70 70
Lines 7416 7454 +38
==========================================
+ Hits 5486 5517 +31
- Misses 1481 1486 +5
- Partials 449 451 +2
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably isn't good for this PR, but it would be nice to add tests for metrics imho.
Maybe with #1168
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
happy uk linter
😂
64970d2
to
33bfcb1
Compare
closes #1153