Fix spamming errors when requesting data from Juno that is not (yet) … #2289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2289 +/- ##
==========================================
- Coverage 75.45% 75.30% -0.15%
==========================================
Files 107 107
Lines 11404 11404
==========================================
- Hits 8605 8588 -17
- Misses 2147 2158 +11
- Partials 652 658 +6 ☔ View full report in Codecov by Sentry. |
AnkushinDaniil
force-pushed
the
daniil/handle-p2p-sync-error
branch
from
a9666a8
to
1e3d578
Compare
kirugan
reviewed
Nov 28, 2024
AnkushinDaniil
force-pushed
the
daniil/handle-p2p-sync-error
branch
from
fa7aa89
to
3725260
Compare
wojciechos
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
p2p/starknet/handlers.gofile to improve error handling and add a new import. The most important changes include adding a new import for thedbpackage and modifying error handling to specifically check fordb.ErrKeyNotFound.Import Addition:
dbpackage to the import list inp2p/starknet/handlers.go.Error Handling Improvements:
processIterationRequestfunction to log errors only if they are notdb.ErrKeyNotFound.processIterationRequestMultifunction to log errors only if they are notdb.ErrKeyNotFound.https://demerzelsolutions.slack.com/archives/C03HL8DH52N/p1732706848085409?thread_ts=1732286243.285989&cid=C03HL8DH52N