Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nil hash validation #2296

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add nil hash validation #2296

wants to merge 3 commits into from

Conversation

AnkushinDaniil
Copy link
Contributor

@AnkushinDaniil AnkushinDaniil commented Dec 1, 2024

Fix #2239
Continue #2290

This pull request introduces protobuf hash validation

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.44%. Comparing base (5107487) to head (fac578b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2296      +/-   ##
==========================================
+ Coverage   75.42%   75.44%   +0.01%     
==========================================
  Files         107      107              
  Lines       11406    11406              
==========================================
+ Hits         8603     8605       +2     
+ Misses       2150     2149       -1     
+ Partials      653      652       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pnowosie pnowosie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Makefile Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Juno panics when receiving Transaction message with nil transaction_hash in P2P sync
2 participants