Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP 7742 implementation #7518
base: master
Are you sure you want to change the base?
EIP 7742 implementation #7518
Changes from 11 commits
de19765
eca6690
7ac90df
9be8a53
c592412
f6ae01c
f803097
7043124
fef9cb2
cc02ce5
206d514
9fbb9c1
8ada4e2
3ae0fed
372868a
0bd75c6
4b5fbfc
5078b76
a92cdde
c032480
4ab5fda
0ba2006
911d232
f806f22
8dc3d6a
a993d59
ba1a3de
87e721a
e52fc98
49424d9
2162240
9d4ec74
d8e088c
793d085
a4fd1ef
d022c4f
47437f2
020ceef
5699ad4
81fb376
332322d
91822aa
b4790dd
36464ad
459ebb7
71963b7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm is this handled correcty?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same thing here, need to skip the logic related to
MaxBlobGasPerBlock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think its assumed that the CL will do the verification regarding the MaxBlockGas/MaxBlobCount because that value is provided for blockProduction?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update: here we can't skip this logic, it might need to be modified
now we recieve MaxBlobCount in payload attributes and we need to use that to construct the block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so the idea with the EIP is to remove validation logic, but here it is for block construction and not validation