Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/unified plugin Enabled flag #8077

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Jan 20, 2025

  • Add Enabled property to INethermindPlugin.
    • Replace IInitializationPlugin.ShouldRunSteps.
    • Replace IConsensusWrapperPlugin.Enabled.
    • Replace IConsensusPlugin.SealEngineType check.
  • To allow plugins to know if it should be enabled, they are given access to IConfigs and ChainSpec from their constructor.
  • Plugins that return false on Enabled is immediately disposed and not added as part of plugin list. No need to check if it enabled manually in Init as that won't be called..
  • IInitializationPlugin now have a GetSteps which return the step explicitly instead of implicit checking assembly.
  • Only one IConsensusPlugin can be enabled now.

Types of changes

What types of changes does your code introduce?

  • New feature (a non-breaking change that adds functionality)

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

  • Testing...

Sorry, something went wrong.

@asdacap asdacap marked this pull request as ready for review February 26, 2025 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants