standardize BlobTxMissingBlobs error message #8129
Open
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
approved these changes
Jan 30, 2025
…actual error, but should be wrapper error
| @@ -221,9 +219,8 @@ public CallOutput CreateAccessList(BlockHeader header, Transaction tx, Cancellat | |||
| TransactionResult tryCallResult = TryCallAndRestore(_processingEnv.Build(header.StateRoot!), header, tx, false, | |||
| new CompositeTxTracer(callOutputTracer, accessTxTracer).WithCancellation(cancellationToken)); | |||
|
|
|||
| return new CallOutput | |||
| return new CallOutput(tryCallResult.Success ? callOutputTracer.Error : tryCallResult.Error, tx.GasLimit) | |||
There was a problem hiding this comment.
I think I would prefer explicit setting the Error property as it was. Just create here a helper method to create error message.
There was a problem hiding this comment.
created a helper function ConstructErrorMessage
LukaszRozmej
approved these changes
Jan 30, 2025
| private string? ConstructError(TransactionResult txResult, string? tracerError, long gasLimit) | ||
| { | ||
| string? error = txResult.Success ? tracerError : txResult.Error; | ||
| return error != null ? $"err: {error} (supplied gas {gasLimit})" : null; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Geth:
Nethermind:
{
"jsonrpc": "2.0",
"id": 1,
"error": {
"code": -32000,
"message": "BlobTxMissingBlobs: Blob transaction must have blobs."
}
}
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Optional. Remove if not applicable.
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs. Remove if not applicable.Requires explanation in Release Notes
If yes, fill in the details here. Remove if not applicable.
Remarks
Optional. Remove if not applicable.