Make names shorter #282
Merged
Make names shorter #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also applies to the main branch, it’s just -dev shorter and problems may arise less frequently. |
anton7c3
approved these changes
Oct 10, 2023
rielas
pushed a commit
that referenced
this pull request
Mar 3, 2024
**Helm Charts.** Sometimes when running tests you may encounter problems like this: `Service “hmm597-7803-e2e-brokencrystals-dev-keycloak-postgres-prod-service” is invalid: metadata.name: Invalid value: “hmm597-7803-e2e-brokencrystals-dev-keycloak-postgres-prod-service”: must be no more than 63 characters` So I shortened the name suffixes and reduced the _trunc_ function parameter to 50, which applies to part of the name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helm Charts.
Sometimes when running tests you may encounter problems like this:
Service “hmm597-7803-e2e-brokencrystals-dev-keycloak-postgres-prod-service” is invalid: metadata.name: Invalid value: “hmm597-7803-e2e-brokencrystals-dev-keycloak-postgres-prod-service”: must be no more than 63 charactersSo I shortened the name suffixes and reduced the trunc function parameter to 50, which applies to part of the name.