Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oas): prevent ReDoS in the BodyConverter #219

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

ostridm
Copy link
Contributor

@ostridm ostridm commented Nov 14, 2023

closes #218

@ostridm ostridm added the Type: refactoring Changes in the way the code works internally without changing the output produced. label Nov 14, 2023
@ostridm ostridm requested a review from derevnjuk November 14, 2023 14:50
@ostridm ostridm self-assigned this Nov 14, 2023
Copy link

codeclimate bot commented Nov 14, 2023

Code Climate has analyzed commit 954b170 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.8% (0.0% change).

View more on Code Climate.

@ostridm ostridm enabled auto-merge (squash) November 14, 2023 14:56
@derevnjuk derevnjuk changed the title refactor(oas): get rid of regexp in BodyConverter refactor(oas): prevent ReDoS in the BodyConverter Nov 14, 2023
@derevnjuk derevnjuk disabled auto-merge November 14, 2023 16:22
@derevnjuk derevnjuk enabled auto-merge (squash) November 14, 2023 16:22
@derevnjuk derevnjuk changed the title refactor(oas): prevent ReDoS in the BodyConverter fix(oas): prevent ReDoS in the BodyConverter Nov 14, 2023
@derevnjuk derevnjuk added Type: bug Something isn't working. and removed Type: refactoring Changes in the way the code works internally without changing the output produced. labels Nov 14, 2023
@derevnjuk derevnjuk disabled auto-merge November 14, 2023 16:25
@derevnjuk derevnjuk enabled auto-merge (squash) November 14, 2023 16:25
@derevnjuk derevnjuk merged commit 30eb0e4 into master Nov 14, 2023
4 checks passed
@derevnjuk derevnjuk deleted the refactor_#218/get-rid-of-regexp-in-body-converter branch November 14, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug Something isn't working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulnerable RegExp in BodyConverter
2 participants