Update README: reference, history, Cobrawap Community #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… doi), (ii) the history of the project (from HBP-Wavescales to present in EBRAINS), (iii) the Cobrawap Community (from Wavescales involved partners to Core-Team, Support-Team and Scientific Partners)
|
see also PR #59 (that is on Update README as well) |
cosimolupo
reviewed
Jun 25, 2024
README.rst
Outdated
| ================= | ||
| Cobrawap was originally developed in the context the `Human Brain Project <https://www.humanbrainproject.eu>`_ and is part of the `EBRAINS <https://www.ebrains.eu>`_ infrastructure. Partners involved in the collaboration and use case within the project (*WaveScalES*) are: | ||
| Cobrawap is currently provided as a `tool <https://www.ebrains.eu/tools/cobrawap>`_ of the `EBRAINS <https://www.ebrains.eu>`_ infrastructure and included in the `EBRAINS-Italy <https://www.ebrains-italy.eu/>`_ initiative. Further details on fundings and resources are in the `Acknowledgments <https://github.com/NeuralEnsemble/cobrawap/blob/master/doc/source/acknowledgments.rst>`_ file in the doc session. |
There was a problem hiding this comment.
At the very end of the statement, there is a typo: "session" -> "section", or even better "folder".
There was a problem hiding this comment.
done. new commit added.
cosimolupo
approved these changes
Jun 25, 2024
mdenker
reviewed
Jul 2, 2024
README.rst
Outdated
Comment on lines
34
to
36
| For researchers to be able to effectively reproduce results and build on each other's progress, it is important to not only make results openly accessible and to facilitate data sharing, but also to build the analysis workflows in a shareable and reusable manner. | ||
|
|
||
| Making analysis scripts available alongside results and datasets is good. What is even better is to design the analysis workflows for specific research questions in such a manner that they are general and flexible enough to be actively reused in further research. In this way, the rigor of the analysis workflow is increased, and the design of the analysis process is simplified for the researcher | ||
| Making analysis scripts available alongside results and datasets is good. What is even better is to design the analysis workflows for specific research questions in such a manner that they are general and flexible enough to be actively reused in further research. In this way, the rigor of the analysis workflow is increased, and the design of the analysis process is simplified for the researcher. |
There was a problem hiding this comment.
I would suggest to remove these two paragraphs. I think these paragraphs had a use before where we did not have Cobrawap out in the open. Today, however, I suppose that someone reading this text will probably just want to know what Cobrawap is, but has little interest on our high-level opinion on how to do research. I would argue shorter is better in this case.
There was a problem hiding this comment.
Fine with me, I agree with your point, we can remove both paragraphs; check if @rgutzen is fine as well, I didn't want to overturn his formulation and communication objective
add paragraph to short list related projects (as SWAVE) Co-authored-by: Michael Denker <[email protected]>
New title for the paragraph requires a longer underline Co-authored-by: Michael Denker <[email protected]>
…owledgments: EBRAINS-InfraServ added in the list of fundings
cosimolupo
reviewed
Jul 3, 2024
mdenker
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
(i) reference updated (from arxive to final doi); (ii) project history updated (from HBP-Wavescales to present status in EBRAINS); (iii) Cobrawap Community updated (from "Wavescales involved partners" to illustration of Core-Team, Support-Team and Scientific Partners, and list of involved people in alphabethical order).
++other minor changes (punctuations, slight reformulations, etc...)