Changing dependencies requirements to be compliant with EBRAINS ESD #83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this Pull Request, the requirements of Cobrawap dependencies have been aligned to the latest EBRAINS Software Distribution (ESD) guidelines.
In more detail, referring to the
pyproject.toml
file:neo
has been removed, since the presence of|
's in config filenames does not seem to be an issue, at variance with initial guess (see also issue Avoid using "|" character in naming profile variants #81 for a discussion on the use of|
's in filenames);ruamel.yaml
version requirement has been slightly changed from ">=0.18.3" to "==0.17.32", in order to have an already compiled version also available via spack;pulp
dependency has been explicitly added and pinned to "<2.8", so to be compatible with the current constraint "<8.0" forsnakemake
(see also issues Replace the deprecated 'subworkflow' snakemake feature #57 and Upper limit for PuLP version < 2.8.0 seems to be required #82).In addition,
requirements/environment-docs.yaml
file has been updated accordingly.Finally, there is a potential change to be done also on
scikit-image
, i.e. relax the version requirement from ">=0.20.0" to ">=0.19.0", so to exploit an already built package in the ESD pipeline. Further checks are needed in this regard.