WIP: Add Charge Current Limit functionality #364
+99
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardoC
requested review from
Willy-JL,
Sil333033,
HaxSam,
MatthewKuKanich and
956MB
as code owners
|
How should I add this to the actual UI to then test it on a real device? Specifically, what's a good example of similar existing functionality I should emulate |
|
I tried to run the tests but they failed with the following, which seems unrelated user@host 15:57:30 last-exit:2 $
./fbt FIRMWARE_APP_SET=unit_tests flash_usb
fbt: warning: Failed parsing manifest '/REDACTED/Momentum-Firmware/applications/external/mtp/application.fam' : Invalid appid '.f0_mtp'. Must match regex 're.compile('^[a-z0-9_]+$')'
LoadAppManifest, line 135, in file "/REDACTED/Momentum-Firmware/scripts/fbt_tools/fbt_apps.py"
fbt: warning: Failed parsing manifest '/REDACTED/Momentum-Firmware/applications/external/mtp/application.fam' : Invalid appid '.f0_mtp'. Must match regex 're.compile('^[a-z0-9_]+$')'
LoadAppManifest, line 135, in file "/REDACTED/Momentum-Firmware/scripts/fbt_tools/fbt_apps.py"
SDKCHK targets/f7/api_symbols.csv
API version 79.2 is up to date
LINK build/f7-firmware-C/firmware.elf
/REDACTED/Momentum-Firmware/toolchain/arm64-darwin/bin/../lib/gcc/arm-none-eabi/12.3.1/../../../../arm-none-eabi/bin/ld: build/f7-firmware-C/applications/debug/unit_tests/unit_test_api_table.o:(.rodata._ZL20unit_tests_api_table+0x34): undefined reference to `js_thread_run'
/REDACTED/Momentum-Firmware/toolchain/arm64-darwin/bin/../lib/gcc/arm-none-eabi/12.3.1/../../../../arm-none-eabi/bin/ld: build/f7-firmware-C/applications/debug/unit_tests/unit_test_api_table.o:(.rodata._ZL20unit_tests_api_table+0x64): undefined reference to `js_thread_stop'
collect2: error: ld returned 1 exit status
scons: *** [build/f7-firmware-C/firmware.elf] Error 1
********** FBT ERRORS **********
build/f7-firmware-C/firmware.elf: Error 1macOS 15.2 (24C101) |
RichardoC
changed the title
|
To clarify as well, despite this accepting values, the chip should have a resistor which also caps the charging current, and the charging chip uses the lower of the two values |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
For the reviewer