Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: make http client pooling #169

Merged
merged 2 commits into from
Sep 26, 2024
Merged

feat!: make http client pooling #169

merged 2 commits into from
Sep 26, 2024

Conversation

hmqgg
Copy link
Member

@hmqgg hmqgg commented Sep 26, 2024

BREAKING CHANGES

  • Signature of utils::make_client()

@hmqgg hmqgg requested a review from nykma September 26, 2024 13:27
nykma
nykma approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@nykma nykma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK. Further performance ovservation should be done online.

@nykma nykma merged commit d1c411a into develop Sep 26, 2024
1 check passed
@nykma nykma deleted the feat/http_pool branch September 26, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nykma nykma nykma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hmqgg @nykma