Fix un-catched exception #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Can you tell me which deno version are you currently running? ( |
|
deno 1.46.3 |
|
Ok I see you mentioned deno 2+ is needed, my bad, I will revert the command line argument then |
Kile
changed the title
NextFire
reviewed
Dec 20, 2024
music-rpc.ts
Outdated
Comment on lines
46
to
54
| if (this.rpc.ipc) { | ||
| console.log("Closing connection to Discord RPC"); | ||
| this.rpc.close(); | ||
| this.rpc.ipc = undefined; | ||
| console.log("Attempting to close connection to Discord RPC"); | ||
| try { | ||
| this.rpc.close(); | ||
| } finally { | ||
| console.log("Connection to Discord RPC closed"); | ||
| this.rpc.ipc = undefined; | ||
| } | ||
| } |
There was a problem hiding this comment.
Can you extract this block to something like this.tryCloseRPC() to avoid having too many nested statements?
There was a problem hiding this comment.
I have also put the if statement in that method, let me know if you want it to take it out again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
Awesome project!
I have started to have an issue a few weeks ago where Apple Music will stop being responsive to pause and skip buttons. I am not sure if this is because of this library, so I looked into it.
I cannot consistently reproduce this issue, but the one time I could, I found an error in the logs at the same time:
Looking into the code, it seems
this.rpc.close();is trusted to not error and any error coming from it is not catched. So in this PR I added atryblock around it. Even if this is not the root cause of my issue, it is still a good idea to catch any errors from this line of code.While running this code locally, I also noticed that it complains aboutso I followed the suggestion and used(I had an outdated deno version)--allow-hrtimeinstead. If this is intended or my system is outdated feel free to let me know and I will revert this change.