-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AUD-70] 코스 목록 API 연동 #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
작업해주셔서 감사합니다 ~!
course api 부분 코드 간단한데 전 왜이렇게 삽질했는지 모르겠네요
익숙하지 않아서 그랬나봅니다... ..
・゚゚・。 /__/\ 。・゚゚・
。・゚゚・( > ᴥ <) ・゚゚・。
...... ((__u_u)
* @param param.pendingFallback Suspense에 넘겨줄 fallback Component | ||
* @param param.rejectedFallback ErrorBoundary의 fallbackRender Props에 넘겨줄 fallback Component | ||
*/ | ||
const AsyncBoundary = ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AsyncBoundary도 해주셨군요!
˖♡ ⁺ ᘏ ⑅ ᘏ
˖°ฅ( • · • ฅ)
@@ -10,13 +10,13 @@ import { COLOR } from '@/styles/foundation'; | |||
import * as S from './CourseTab.css'; | |||
|
|||
interface PropsType { | |||
name: string; | |||
courseName: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
courseName이 더 직관적인 것 같긴 하네요
</div> | ||
); | ||
const CoursesContainer = ({ selectedCourseTab }: PropsType) => { | ||
console.log(selectedCourseTab); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.log는 지워도 될 것 같습니다
const { data: wholeCourses } = useGetCourses({ | ||
limit: 10, | ||
enabled: selectedCourseTab === 'allCourse', | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TMI이지만 제가 이 부분에서 뭐가 안돼서 삽질했었는데
도대체 왜 안됐는지 모르겠네요
쩝
📃 변경사항
useIntersectionObserver
Hook 을 기반으로 무한 스크롤 기능을 추가했습니다.AsyncBoundary
컴포넌트를 추가했습니다🫨 고민한 부분 (optional)
💫 기타사항 (optional)