Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AUD-112] 코스탭에서 코스명 수정 기능 구현 #64

Merged
merged 13 commits into from
Mar 1, 2024

Conversation

KimGaeun0806
Copy link
Member

@KimGaeun0806 KimGaeun0806 commented Feb 28, 2024

📃 변경사항

  • 코스탭에서 코스명 수정하는 기능 추가
  • usePatchCourseName에 queryClient.invalidateQueries({queryKey: COURSE_QUERY_KEY.list()}); 추가

🎇 동작 화면

2024-02-29.2.12.27.mov

++ 닫기 버튼 추가했습니다
image

💫 기타사항

  • 프레이머에 뭔가 문제가 있어서 인풋 디자인이 안보이는 상태입니다 ㅜ 추후 디자인 수정하겠습니다
  • 이전 PR에서도 잠깐 말했지만
    디자인이 같은 모달들은 중복되는 코드가 많은 것 같습니다. 추후 컴포넌트화를 하면 좋을 것 같아요

@KimGaeun0806 KimGaeun0806 added the ✨ Feature 기능 개발 label Feb 28, 2024
@KimGaeun0806 KimGaeun0806 self-assigned this Feb 28, 2024
Comment on lines 13 to 15
backgroundColor: 'rgba(0, 0, 0, 0.33)'
})
backgroundColor: 'rgba(0, 0, 0, 0.33)',
});
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

자꾸 이런데서 변경사항이 생기네요 ;;

@RookieAND
Copy link
Collaborator

디자인 수정 완료 이후에 PR 리뷰 진행하겠습니다.
추가로 Modal의 경우 최대한 다양한 케이스를 고려하긴 했으나, 여차하면 자주 쓰는 스타일 (본문 텍스트, 버튼) 은 Modal.css.ts 에서 가져오는 방식도 고려해보겠습니다.

@KimGaeun0806
Copy link
Member Author

@RookieAND
디자인 수정 완료했습니다
image

Copy link
Collaborator

@RookieAND RookieAND left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.

Base automatically changed from feature/AUD-108 to develop March 1, 2024 07:45
@KimGaeun0806 KimGaeun0806 merged commit b65eba2 into develop Mar 1, 2024
1 check passed
@KimGaeun0806 KimGaeun0806 deleted the feature/AUD-112 branch March 1, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 기능 개발
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants