마이페이지-설정 디자인 & 기능 일부 #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 메모리 관리 - 로직 및 코드 단순화
enebin
commented
Sep 4, 2023
There was a problem hiding this comment.
가끔 스택 넘칠 때가 있는데 그 때 이걸로 감싸주면 '임시로' 해결 되는 듯함. 첨부터 스토어 한 개만 있게끔 설계하는게 베스트긴 한 것 같은데 내가 지금 숙련도가 딸려서;; 스택 터지는데 고칠 시간 없을 때 최후의 보루로서 사용해주심 될듯
There was a problem hiding this comment.
웹 뷰 헤더에 토큰을 넣어달라는 요청이 있었음. 이건 디코 프론트엔드 요청 쓰레드 보면 나와있음.
웹 쪽에선 지금 헤더를 못 받고 있다고 해서 아직 이게 스펙으로 확정되진 않을 수도 있음.
There was a problem hiding this comment.
SwitchStore를 써서 로직을 좀 간단하게 만들었음.
0inn
approved these changes
Sep 6, 2023
| /// 스택 오버플로우 방지용 래퍼 | ||
| /// 참고: https://github.com/pointfreeco/swift-composable-architecture/discussions/488 | ||
| @propertyWrapper | ||
| public struct Box<T: Equatable>: Equatable { |
enebin
force-pushed
the
feature/setting-view(#89)
branch
from
2e5d710
to
f750031
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-09-04.at.19.58.08.mp4
기타