deleteDocument not return boolean as a result.

Nexucis · Oct 21, 2017 · f976c13 · f976c13
1 parent f512aa7
commit f976c13
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/Nexucis/Elasticsearch/Helper/Nodowntime/IndexHelper.php b/src/Nexucis/Elasticsearch/Helper/Nodowntime/IndexHelper.php
@@ -498,7 +498,7 @@ public function deleteAllDocuments($alias)
      * @param $alias [REQUIRED]
      * @param $id [REQUIRED]
      * @param string $type [REQUIRED]
-     * @return boolean
+     * @return void
      * @throws IndexNotFoundException
      */
     public function deleteDocument($alias, $id, $type)
@@ -513,8 +513,7 @@ public function deleteDocument($alias, $id, $type)
             'id' => $id,
         );
 
-        $response = $this->client->delete($params);
-        return $response['found'] > 0;
+        $this->client->delete($params);
     }
 
     /**

diff --git a/src/Nexucis/Elasticsearch/Helper/Nodowntime/IndexHelperInterface.php b/src/Nexucis/Elasticsearch/Helper/Nodowntime/IndexHelperInterface.php
@@ -186,7 +186,7 @@ public function deleteAllDocuments($alias);
      * @param $alias [REQUIRED]
      * @param $id [REQUIRED]
      * @param string $type [REQUIRED]
-     * @return bool
+     * @return void
      * @throws IndexNotFoundException
      */
     public function deleteDocument($alias, $id, $type);

diff --git a/tests/Nexucis/Tests/Elasticsearch/Helper/Nodowntime/DocumentActionTest.php b/tests/Nexucis/Tests/Elasticsearch/Helper/Nodowntime/DocumentActionTest.php
@@ -124,18 +124,19 @@ public function testDeleteDocument($alias)
 
         $this->assertTrue(self::$HELPER->addDocument($alias, $type, $body, $id));
 
-        $this->assertTrue(self::$HELPER->deleteDocument($alias, $id, $type));
+        self::$HELPER->deleteDocument($alias, $id, $type);
     }
 
     /**
      * @dataProvider aliasDataProvider
+     * @expectedException \Elasticsearch\Common\Exceptions\Missing404Exception
      */
     public function testDocumentNotExist($alias)
     {
         $type = 'test';
         $id = 0;
         self::$HELPER->createIndex($alias);
-        $this->assertFalse(self::$HELPER->deleteDocument($alias, $id, $type));
+        self::$HELPER->deleteDocument($alias, $id, $type);
     }
 
     /**