-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics): Add custom prometheus port support and log entry #61
Conversation
📝 WalkthroughWalkthroughThe changes modify the environment configuration and the server startup process. The Changes
Sequence Diagram(s)sequenceDiagram
participant App as Application
participant Env as Environment
participant Log as Logger
participant HTTP as HTTP Server
App->>Env: Read METRICS_PORT
Env-->>App: Return custom port or null
App->>App: Set metricsPort (custom or "8080")
App->>Log: Log chosen port
App->>HTTP: Start server on metricsPort
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.env.example
(1 hunks)cmd/root.go
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- .env.example
🧰 Additional context used
🪛 golangci-lint (1.62.2)
cmd/root.go
77-77: Error return value of http.ListenAndServe
is not checked
(errcheck)
🔇 Additional comments (1)
cmd/root.go (1)
71-75
: LGTM!The implementation of custom port support through the environment variable is clean and maintains backward compatibility with the default port 8080. The added log message provides clear visibility into which port is being used.
This allows an environment variable to specify a port for prometheus in case 8080 cannot be used. It's been tested without the variable and defaults to 8080, and tested with a custom port. The log will accurately post which port prometheus is using after the binary starts.