Hide single dot #206
Open
Hide single dot #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickPiscitelli
requested changes
Aug 12, 2022
| @@ -210,6 +208,10 @@ | |||
| _.dots.innerHTML = '' | |||
| _.dots.classList.add('glider-dots') | |||
|
|
|||
| //hide single dot | |||
| if (Math.ceil(_.slides.length / _.opt.slidesToShow) == 1) return; | |||
There was a problem hiding this comment.
Store this to a variable and then use it later in the loop to prevent the redundant calculation
There was a problem hiding this comment.
HI Nick, thanks for considering my contribution.
Let's see if I understand it right.
Are you asking something like:
var dots = Math.ceil(_.slides.length / _.opt.slidesToShow)
if(dots==1) return
for (var i = 0; i < dots; ++i) {
Is that the change you are asking for?
regards
Lorenzo
NickPiscitelli
force-pushed
the
master
branch
from
df4a48d to
1358051
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't show a single dot. Avoid generating it.