feat(changelog): overwrite file if configured, pass max file size in MB #67
Conversation
fwiedmann
force-pushed
the
feat/changelog
branch
from
f33b46c to
628aa27
Compare
Yes, good idea! What would be a good file limit? Or we could limit it by the count of existing release changelogs in a file. A separator for this kind of solution could be the markdown line When a file limit / or max count of releases exceed, I would copy the current file to -[0-9].md |
|
Maybe we can start with 10 MB? Else we can make it changeable via the config file. |
|
@fwiedmann are you still working on it? |
|
Yes still WIP. I can work on this again next weekend ;) |
remove version 1.13, 1.14
…write to overwrite the whole file BREAKING CHANGE: changelog command will now prepend changelogs to the changelog-file
…e log file if exceeded.feat/changelog still in WIO
fwiedmann
changed the title
|
@Nightapes The basics are done. Could you review the current changes? What is still missing:
|
| @@ -8,7 +8,9 @@ import ( | |||
|
|
|||
| func init() { | |||
| changelogCmd.Flags().Bool("checks", false, "Check for missing values and envs") | |||
| changelogCmd.Flags().Bool("overwrite", false, "Overwrite the content of the changelog. Default is to prepend the new changelog to the existing file.") | |||
There was a problem hiding this comment.
Should we add the flags to the release commands and write the changelog there too?
There was a problem hiding this comment.
This would only improve the workflow if the users running the release command on their local machine right?
So If yes, I think they can run two commands :D
There was a problem hiding this comment.
True, but there are custom setups. But this can be done in a extra PR
For #55.
--max-file-sizecheck if an existing file exceeds the limit. If yes the current file will be moved tofilename-<1-n>.file-extension. The new changelog will be written to--overwritewill overwrite the current changelog file with the new generated changelog.