WIP: circleci version 2 migration #63
Conversation
|
It's ok for me but I have a question about ruby docker image for CI. I wanted to fix docker image to |
|
Ah, damn. I'll ask about the docker image to my contacts at Circle on slack |
|
Quoting Danielle:
Probably not worth the hassle though. |
.circleci/config.yml
Outdated
| command: ruby -v | ||
| - run: | ||
| name: Which bundler? | ||
| command: bundle -v |
There was a problem hiding this comment.
Open question: wondering if we want to keep that (assuming it was for debugging the migration)? I guess it's harmless…
There was a problem hiding this comment.
for bundler I am not sur this version check is necessary but for ruby, because of latest image set on config.yml, I wanted to show on which version CI execute build and tests. So do we keep the bundler version ? I have no arguments to keep it.
.circleci/config.yml
Outdated
| command: bundle -v | ||
| - run: | ||
| name: Bundle Install | ||
| command: bundle check || bundle install |
There was a problem hiding this comment.
Is bundle check || really necessary? I may be wrong but I think bundle install is a no-op if the bundle is already up-to-date, so just bundle install could be enough there?
There was a problem hiding this comment.
I found interesting things about this command. Initialy I copy paste it from CircleCi config for ruby project. But when you commented this line I searched explanation on bundler. I found this issue #95. related to this line bundler.cap
So when bundle install is launched a test with bundle check is executed.
So I will delete bundle check command.
|
Bad news for docker image. I am agree with you, it's not worth to maintain by ourselves. |
.circleci/config.yml
Outdated
| docker: | ||
| - image: drecom/ubuntu-ruby:2.0.0-p648 | ||
| steps: | ||
| - checkout |
There was a problem hiding this comment.
You probably don't want to checkout on each and every step!
|
Ok I implement workflows but github waiting for circleci status. I found a documentation about this but I am not able to access gyro settings. |
|
I think before merging this PR, it will be useful to squash it into one commit. |
Using workflows to test against both Ruby 2.0.0 & latest ruby
AliSoftware
force-pushed
the
feature/circleci-2-migration
branch
from
49219e1 to
36575bb
Compare
This PR is the WIP migration from circleCi 1 to 2. I need additional tests to succeed env management inside rakefile. fix #60