Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/delta merge builder instance check for connect + util fix #130

Merged
merged 5 commits into from
Nov 26, 2024
Merged

Fix/delta merge builder instance check for connect + util fix #130

merged 5 commits into from
Nov 26, 2024

Conversation

dannymeijer
Copy link
Member

@dannymeijer dannymeijer commented Nov 26, 2024 •
edited
Loading

Description

Additonal fixes for #101 and #102

Related Issue

#101, #102

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dannymeijer dannymeijer requested a review from a team as a code owner November 26, 2024 10:25
@dannymeijer dannymeijer changed the base branch from main to release/0.9 November 26, 2024 10:25
@dannymeijer dannymeijer self-assigned this Nov 26, 2024
@dannymeijer dannymeijer linked an issue Nov 26, 2024 that may be closed by this pull request
[BUG] Koheesio 0.9.0 and Spark Connect: delta.connect present only on Databricks #101
Closed
@dannymeijer dannymeijer added this to the 0.9.0 milestone Nov 26, 2024
@dannymeijer dannymeijer linked an issue Nov 26, 2024 that may be closed by this pull request
[BUG] Spark Connect not detected on Databricks #102
Closed
@dannymeijer dannymeijer changed the title Fix/delta merge builder instance check for connect Fix/delta merge builder instance check for connect + util fix Nov 26, 2024
@dannymeijer dannymeijer added the bug Something isn't working label Nov 26, 2024
mikita-sakalouski
mikita-sakalouski approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@mikita-sakalouski mikita-sakalouski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM

@dannymeijer dannymeijer merged commit c72f381 into release/0.9 Nov 26, 2024
1 check passed
@dannymeijer dannymeijer deleted the fix/delta_merge_builder_instance_check_for_connect branch November 26, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikita-sakalouski mikita-sakalouski mikita-sakalouski approved these changes

Assignees

@dannymeijer dannymeijer

Labels
bug Something isn't working
Projects
Koheesio
Status: Done
Milestone
0.9.0
2 participants
@dannymeijer @mikita-sakalouski